Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cacheInvalidateCallback does not work #2626

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Fix cacheInvalidateCallback does not work #2626

merged 1 commit into from
Feb 16, 2023

Conversation

shiyuhang0
Copy link
Member

What problem does this PR solve?

see #2532 for more details

What is changed and how it works?

see #2532 for more details

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 15, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xuanyu66
  • zhangyangyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0 shiyuhang0 added needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4 needs-cherry-pick-release-2.5 PR which needs to be cherry-picked to release-2.5 labels Feb 16, 2023
@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3729b84

@ti-chi-bot ti-chi-bot merged commit 9b065cc into pingcap:release-3.0 Feb 16, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 16, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-2.4: #2627.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Feb 16, 2023
@shiyuhang0 @ti-chi-bot
This is an automated cherry-pick of pingcap#2626
21144ae 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 16, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-2.5: #2628.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Feb 16, 2023
@shiyuhang0 @ti-chi-bot
This is an automated cherry-pick of pingcap#2626
5c58ca4 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Feb 17, 2023
@ti-chi-bot
Fix cacheInvalidateCallback does not work (#2626) (#2627)
de80f85
ti-chi-bot added a commit that referenced this pull request Feb 17, 2023
@ti-chi-bot
Fix cacheInvalidateCallback does not work (#2626) (#2628)
f0c54a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuanyu66 xuanyu66 xuanyu66 approved these changes

@zhangyangyu zhangyangyu zhangyangyu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4 needs-cherry-pick-release-2.5 PR which needs to be cherry-picked to release-2.5 status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shiyuhang0 @ti-chi-bot @zhangyangyu @xuanyu66